Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from sparklemotion:main #3

Open
wants to merge 1,772 commits into
base: main
Choose a base branch
from
Open

Conversation

pull[bot]
Copy link

@pull pull bot commented Oct 22, 2021

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@pull pull bot added the ⤵️ pull label Oct 22, 2021
@google-cla
Copy link

google-cla bot commented Oct 22, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

15 similar comments
@google-cla
Copy link

google-cla bot commented Oct 23, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Oct 23, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Oct 23, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Oct 26, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Oct 27, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Oct 28, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Nov 3, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Nov 3, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Nov 6, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Nov 6, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Nov 12, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Nov 15, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Nov 15, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Nov 15, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Nov 15, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Trying to address concerns raised in #1053.

[skip ci]
…3268)

**What problem is this PR intended to solve?**

Closes #1523


**Have you included adequate test coverage?**

Yes.

**Does this change affect the behavior of either the C or the Java
implementations?**

This makes the Java impl behave like the C impl.
The behavior is different between Java and C impls in a way that I
don't care enough to fix. Let's document the difference and move on
with our lives.
…3269)

**What problem is this PR intended to solve?**

The behavior is different between Java and C impls in a way that I don't
care enough to fix. Let's document the difference and move on with our
lives.

Closes #1758

**Have you included adequate test coverage?**

Yes.


**Does this change affect the behavior of either the C or the Java
implementations?**

N/A
Let's just work around it in the tests. The behavior we're testing
isn't specific to UTF-8, so let's just swap in ISO-2022-JP.

GNOME/libxml2@6d8427dc
…3271)

**What problem is this PR intended to solve?**

Example failure:
https://github.com/sparklemotion/nokogiri/actions/runs/9774049613/job/26981486984

Let's just work around it in the tests. The behavior we're testing isn't
specific to UTF-8, so let's just swap in ISO-2022-JP.

GNOME/libxml2@6d8427dc

Tagging @nwellnhof just for awareness.


**Have you included adequate test coverage?**

Yes


**Does this change affect the behavior of either the C or the Java
implementations?**

N/A
Two things getting fixed here:

1. We were not calling `setFeature(FEATURE_NOT_EXPAND_ENTITY, ...)` correctly. It defaults to true, and we were conditionally setting it to true. Instead, let's just explicitly set this feature (and the other features we care about) to avoid mistaken assumptions about the default.

2. We were rendering the children of the EntityReference, which contains the replacement text, as well as the EntityReference itself. We should only ever render one or the other. If NOENT is false, though, there won't be any EntityReferences in the DOM. So: if we encounter an EntityReference, don't render its children.

See https://xerces.apache.org/xerces-j/features.html section on `create-entity-ref-nodes` for a deeper explanation of the parser behavior.

Closes #3270
…3272)

**What problem is this PR intended to solve?**

Two things getting fixed here:

1. We were not calling `setFeature(FEATURE_NOT_EXPAND_ENTITY, ...)`
correctly. It defaults to true, and we were conditionally setting it to
true. Instead, let's just explicitly set this feature (and the other
features we care about) to avoid mistaken assumptions about the default.

2. We were rendering the children of the EntityReference, which contains
the replacement text, as well as the EntityReference itself. We should
only ever render one or the other. If NOENT is false, though, there
won't be any EntityReferences in the DOM. So: if we encounter an
EntityReference, don't render its children.

See https://xerces.apache.org/xerces-j/features.html section on
`create-entity-ref-nodes` for a deeper explanation of the parser
behavior.

Closes #3270


**Have you included adequate test coverage?**

Yes


**Does this change affect the behavior of either the C or the Java
implementations?**

This fixes a bug in the Java implementation, so it behaves like the C
impl.
unless the test specifies one or the other.

Closes #3242
flavorjones and others added 30 commits January 5, 2025 21:42
Updates the requirements on [ruby_memcheck](https://github.com/Shopify/ruby_memcheck) to permit the latest version.
- [Release notes](https://github.com/Shopify/ruby_memcheck/releases)
- [Commits](Shopify/ruby_memcheck@3.0.0...3.0.1)

---
updated-dependencies:
- dependency-name: ruby_memcheck
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
- drop adding the flat namespace linker flag which rcd injects for us
- detect the need for darwin linker hack based on linker flags, not ruby version
**What problem is this PR intended to solve?**

Bump rake-compiler-dock to 1.8.0, see
https://github.com/rake-compiler/rake-compiler-dock/releases/tag/v1.8.0
Updates the requirements on [rake-compiler](https://github.com/luislavena/rake-compiler) to permit the latest version.
- [Release notes](https://github.com/luislavena/rake-compiler/releases)
- [Changelog](https://github.com/rake-compiler/rake-compiler/blob/master/History.md)
- [Commits](rake-compiler/rake-compiler@v1.2.8...v1.2.9)

---
updated-dependencies:
- dependency-name: rake-compiler
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Updates the requirements on [rubyzip](https://github.com/rubyzip/rubyzip) to permit the latest version.
- [Release notes](https://github.com/rubyzip/rubyzip/releases)
- [Changelog](https://github.com/rubyzip/rubyzip/blob/master/Changelog.md)
- [Commits](rubyzip/rubyzip@v2.3.2...v2.4.1)

---
updated-dependencies:
- dependency-name: rubyzip
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
**What problem is this PR intended to solve?**

Recently we've been getting upstream CI failures for libxml2 head on
ubuntu:
https://github.com/sparklemotion/nokogiri/actions/runs/12705536326/job/35416744559

```
configure:15841: checking for liblzma
configure:15848: $PKG_CONFIG --exists --print-errors "liblzma"
Package liblzma was not found in the pkg-config search path.
Perhaps you should add the directory containing `liblzma.pc'
to the PKG_CONFIG_PATH environment variable
Package 'liblzma', required by 'virtual:world', not found
configure:15851: $? = 1
configure:15865: $PKG_CONFIG --exists --print-errors "liblzma"
*** ../../../../ext/nokogiri/extconf.rb failed ***
```
to reflect modern bundler usage
When performing a CSS selector query, an XML document's root namespace
declarations are injected into the XPathVisitor, and the default
namespace is applied to any non-namespaced element in the resulting
xpath query.

However, the wildcard selector "*" should not have this namespace
applied. This regressed in v1.17.0 with 179d74d.

Fixes #3411
this time, it's the ruby:alpine images that removed all the -dev
libraries. JFC i'm just trying to stay green here.
…3413)

**What problem is this PR intended to solve?**

When performing a CSS selector query, an XML document's root namespace
declarations are injected into the XPathVisitor, and the default
namespace is applied to any non-namespaced element in the resulting
xpath query.

However, the wildcard selector "*" should not have this namespace
applied. This regressed in v1.17.0 with 179d74d.

Fixes #3411


**Have you included adequate test coverage?**

Yes.


**Does this change affect the behavior of either the C or the Java
implementations?**

N/A
**What problem is this PR intended to solve?**

Adds a doc about "modernized" call-seqs.

A modernized method's doc can link to this doc. This should allow a
simpler discussion in the method's doc.

**Have you included adequate test coverage?**

Doc only.

**Does this change affect the behavior of either the C or the Java
implementations?**

No.
Updates the requirements on [standard](https://github.com/standardrb/standard) to permit the latest version.
- [Release notes](https://github.com/standardrb/standard/releases)
- [Changelog](https://github.com/standardrb/standard/blob/main/CHANGELOG.md)
- [Commits](standardrb/standard@v1.43.0...v1.44.0)

---
updated-dependencies:
- dependency-name: standard
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Updates the requirements on [rdoc](https://github.com/ruby/rdoc) to permit the latest version.
- [Release notes](https://github.com/ruby/rdoc/releases)
- [Changelog](https://github.com/ruby/rdoc/blob/master/History.rdoc)
- [Commits](ruby/rdoc@v6.10.0...v6.11.0)

---
updated-dependencies:
- dependency-name: rdoc
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
and replace the .cross_rubies file with misc/native.yml
**What problem is this PR intended to solve?**

Update to rake-compiler-dock v1.9.1 and replace the .cross_rubies file
with misc/native.yml
**What problem is this PR intended to solve?**

Improvements to doc for XML::ParseOptions.

**Have you included adequate test coverage?**

N/A.  All doc.

**Does this change affect the behavior of either the C or the Java
implementations?**

No.

---------

Co-authored-by: Mike Dalessio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.